[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking
On Thu, Dec 22, 2016 at 11:22 AM, Ian Jackson <ian.jackson@xxxxxxxxxxxxx> wrote: > Alistair Francis writes ("Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded > strict -Werror checking"): >> On Thu, Dec 22, 2016 at 12:41 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote: >>> On 20.12.16 at 20:46, <alistair.francis@xxxxxxxxxx> wrote: >> >> Signed-off-by: Alistair Francis <alistair.francis@xxxxxxxxxx> >> > >> > Without some rationale given I don't think such changes are >> > acceptable at all. And then, as already pointed out others, the >> > use of -Werror is there not just for fun. If anything I think an >> > override to that default could be acceptable. >> >> Unfortunately the APPEND_CFLAGS=-Wno-error doesn't fix all the issues >> as I still see warnings/errors when building: tools/kconfig/conf.c. > > That sounds like a bug to me. Do you know why it's not effective > there ? It actually might be an issue in the way buildroot is handling the arguments. I'll look into it and see what I find after the holidays. Thanks, Alistair > >> Everyone seems fairly open to an override. Is a environment variable, >> which if set will disable Werror acceptable? Something like NO_ERROR=Y >> which will result in no -Werror being appended. > > Yes, an environment variable would be acceptable, but it should have > the right name and semantics and ideally we could reuse an existing > variable or fix it if it is broken. > > How about `APPEND_CFLAGS=-Wno-error' ? :-) > > Thanks, > Ian. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxx > https://lists.xen.org/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |