Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 27/12/16 15:53, Jan Beulich wrote:
> > > > "Jan Beulich" <jbeulich@xxxxxxxx> 12/27/16 4:42 PM >>>
> > > > Alistair Francis <alistair.francis@xxxxxxxxxx> 12/22/16 8:14 PM >>>
> > > Everyone seems fairly open to an override. Is a environment variable,
> > > which if set will disable Werror acceptable? Something like NO_ERROR=Y
> > > which will result in no -Werror being appended.
> > I dislike environment variables for such purposes, and would prefer requiring
> > such to be added as make options. If it was an environment variable, it
> > should start with XEN_. And its name should fully reflect the purpose, i.e. I
> > shouldn't have to guess what kinds of errors would be suppressed. Perhaps
> > WARN_NO_ERROR?
> That said, I'm not sure everyone agreed on putting an override in place. I think
> Andrew had made it quite clear that there is a reason for -Werror to be in use,
> and we shouldn't encourage people weakening code by tolerating warnings
> (even if for the purpose of upstream integration no warnings will be permitted
> anyway, due to -Werror remaining the default).
For development, -Werror should remain the default.

For downstream integration, an ability to override -Werror is useful for 
distros, especially in cases of using a newer compiler than the code was 
ever developed against.
However, it should definitely be the case that a positive choice needs 
to be taken to disable -Werror, which should hopefully make people thing 
twice about doing so.
~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel