Re: [Xen-devel] [PATCH] x86: use unambiguous register names

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 05/01/17 10:50, Jan Beulich wrote:
> Eliminate the mis-naming of 64-bit fields with 32-bit register names
> (eflags instead of rflags etc). To ensure no piece of code was missed,
> transiently use the underscore prefixed names only for 32-bit register
> accesses. This will be cleaned up subsequently.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

> ---
> This is part II of the register renaming project. My intention is for
> things to stay this way for a couple of weeks, so people having patches
> in progress can update accordingly before we switch from the _e* names
> to the proper e* ones.

I bet that noone is going to notice that they even need make changes
until the build breaks.

I'd recommend getting part 3 done sooner rather than later, leaving a
some commented-out code to reintroduce the _e* names, which people can
patch locally if they can't get get around to updating the names at
once.  That commented-out code can then stay for a couple of weeks, as a
grace period.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel