Re: [Xen-devel] [PATCH 2/3] x86emul: support {,V}LDDQU

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 14/12/16 09:56, Jan Beulich wrote:
> Also take the opportunity and adjust the vmovdqu test case the new one
> here has been cloned from: To zero a ymm register we don't need to go
> through hoops, as 128-bit AVX insns zero the upper portion of the
> destination register, and in the disabled AVX2 code there was a wrong
> YMM register used.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

This change in isolation does look correct, but it does further add to
the readability/comprehendability problems I raised in the previous patch.

As long as we can suitably address those issues, this should be fine.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel