Re: [Xen-devel] [PATCH v5 1/9] xen/x86: remove XENFEAT_hvm_pirqs for PVHv2 guests

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 19/01/17 17:29, Roger Pau Monne wrote:
> @@ -3768,7 +3770,9 @@ static long hvm_physdev_op(int cmd, 
> XEN_GUEST_HANDLE_PARAM(void) arg)
>      case PHYSDEVOP_eoi:
>      case PHYSDEVOP_irq_status_query:
>      case PHYSDEVOP_get_free_pirq:
> -        return do_physdev_op(cmd, arg);
> +        return ((currd->arch.emulation_flags & XEN_X86_EMU_USE_PIRQ) ||

How about:

#define uses_pirqs(d)      (!!((d)->arch.emulation_flags &
XEN_X86_EMU_USE_PIRQ))

to match the other emulation flags predicates (or some suitable naming)?

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel