Re: [Xen-devel] [PATCH v5 1/9] xen/x86: remove XENFEAT_hvm_pirqs for PVHv2 guests

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Fri, Jan 20, 2017 at 06:41:21PM +0000, Andrew Cooper wrote:
> On 19/01/17 17:29, Roger Pau Monne wrote:
> > @@ -3768,7 +3770,9 @@ static long hvm_physdev_op(int cmd, 
> > XEN_GUEST_HANDLE_PARAM(void) arg)
> >      case PHYSDEVOP_eoi:
> >      case PHYSDEVOP_irq_status_query:
> >      case PHYSDEVOP_get_free_pirq:
> > -        return do_physdev_op(cmd, arg);
> > +        return ((currd->arch.emulation_flags & XEN_X86_EMU_USE_PIRQ) ||
> 
> How about:
> 
> #define uses_pirqs(d)      (!!((d)->arch.emulation_flags &
> XEN_X86_EMU_USE_PIRQ))

I've named it "has_pirq" in order to match with the other options, that all use
the has_ prefix (has_use_pirq sounds too strange IMHO).

> to match the other emulation flags predicates (or some suitable naming)?
> 
> Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel