Re: [Xen-devel] [PATCH v2 02/12] x86: extract macros to x86-defns.h

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.01.17 at 12:07, <wei.liu2@xxxxxxxxxx> wrote:
> +/*
> + * Trap/fault mnemonics.
> + */
> +#define TRAP_divide_error      0
> +#define TRAP_debug             1
> +#define TRAP_nmi               2
> +#define TRAP_int3              3
> +#define TRAP_overflow          4
> +#define TRAP_bounds            5
> +#define TRAP_invalid_op        6
> +#define TRAP_no_device         7
> +#define TRAP_double_fault      8
> +#define TRAP_copro_seg         9
> +#define TRAP_invalid_tss      10
> +#define TRAP_no_segment       11
> +#define TRAP_stack_error      12
> +#define TRAP_gp_fault         13
> +#define TRAP_page_fault       14
> +#define TRAP_spurious_int     15
> +#define TRAP_copro_error      16
> +#define TRAP_alignment_check  17
> +#define TRAP_machine_check    18
> +#define TRAP_simd_error       19
> +#define TRAP_virtualisation   20
> +#define TRAP_nr               32
> +
> +#define TRAP_HAVE_EC                                                    \
> +    ((1u << TRAP_double_fault) | (1u << TRAP_invalid_tss) |             \
> +     (1u << TRAP_no_segment) | (1u << TRAP_stack_error) |               \
> +     (1u << TRAP_gp_fault) | (1u << TRAP_page_fault) |                  \
> +     (1u << TRAP_alignment_check))

I agree with Andrew's reply to another patch: These shouldn't be
moved here, and we should transition over to X86_EXC_*.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel