Re: [Xen-devel] [PATCH v2 03/12] x86: extract vendor numeric id to x86-vendors.h

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.01.17 at 12:08, <wei.liu2@xxxxxxxxxx> wrote:
> They will be shared between xen and userspace programs.

Please clarify here that this is not strictly necessary, but rather just
a convenience / reduction of overall code size. Otherwise someone
looking back in a couple of years may wonder where the hidden
dependency is for values to be identical between hypervisor and
user space testing code.

> No functional change.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

With the above clarification in place,
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel