[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] arm: alloc_heap_pages allocates already allocated page

On Tue, Feb 7, 2017 at 6:57 PM, Julien Grall <julien.grall@xxxxxxx> wrote:
> On 07/02/2017 13:25, Vijay Kilari wrote:
>> On Tue, Feb 7, 2017 at 6:30 PM, Julien Grall <julien.grall@xxxxxxx> wrote:
>>> One more thing, if Xen 4.7 was able to go up to booting Dom0 without any
>>> patches on a NUMA board. I would recommend to try to bisect and see if
>>> you
>>> can find an offending commit.
>>   Yes, with plain 4.7 panic is not seen
> Can you please bisect Xen? It could save us a bit of time to understand
> what's going on.

ubuntu@ubuntu:~/xen_upstream_new/xen$ git bisect bad
493f535a06b5b4041c0745e954780dd5d6f80581 is the first bad commit
commit 493f535a06b5b4041c0745e954780dd5d6f80581
Author: Julien Grall <julien.grall@xxxxxxx>
Date:   Thu Sep 15 12:28:36 2016 +0100

    xen/arm: p2m: Re-implement p2m_insert_mapping using p2m_set_entry

    The function p2m_insert_mapping can be re-implemented using the generic
    function p2m_set_entry.

    Note that the mapping is not reverted anymore if Xen fails to insert a
    mapping. This was added to ensure the MMIO are not kept half-mapped
    in case of failure and to follow the x86 counterpart. This was removed
    on the x86 part by commit c3c756bd "x86/p2m: use large pages for MMIO
    mappings" and I think we should let the caller taking care of it.

    Finally drop the operation INSERT in apply_* as nobody is using it
    anymore. Note that the functions could have been dropped in one go at the
    end, however I find easier to drop the operations one by one avoiding a
    big deletion in the patch that convert the last operation.

    Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
    Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
    Tested-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>

:040000 040000 4fb3f181a7b0f9b46f9b573e7a328b4b77dcaa78
d3fc51e4175b86504eac644084ee45a18492641e M    xen

> I will look at the log and answer in a separate e-mail.
> Regards,
> --
> Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.