Re: [Xen-devel] [PATCH 0/2] tools: split xl into a separate directory

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Feb 23, 2017 at 04:59:34PM +0000, Wei Liu wrote:
> On Thu, Feb 23, 2017 at 04:29:46PM +0000, Ian Jackson wrote:
> > Wei Liu writes ("Re: [PATCH 0/2] tools: split xl into a separate 
> > directory"):
> > > On Thu, Feb 23, 2017 at 03:54:02PM +0000, Ian Jackson wrote:
> > > > No, this is entirely wrong.  You will end up running make in
> > > > tools/libxl twice simultaneously.
> > > 
> > > Libacpi can be built in different directories by setting ACPI_BUILD_DIR.
> > 
> > Aha.  So it's built multiple times (presumably with different build
> > options, etc).
> > 
> > > Libxl doesn't have that, yet. We can do that, too. But it might involve
> > > quite a bit of fiddling with libxl/Makefile.
> > 
> > This is not the right approach for libxl.
> > 
> > Rather the parent Makefile should have a dependency, so that the make
> > in `tools' knows to complete libxl before starting xl.
> > 
> 
> I think this is better.
> 
> But I am now very confused how we encode this in our build system.
> Obviously there is already such need. Say, all the tools under misc
> would require libxc to be built before hand, but the dependency
> doesn't seem to be explicitly encoded.
> 

OIC: the order matters in tools/Makefile

I just need to move

SUBDIRS-y += xl after SUBDIRS-y += libxl

Let me know what you think.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel