Re: [Xen-devel] [PATCH v2 5/6] x86_emulate: Remove dependency on __LINE__ for release builds

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.03.17 at 18:46, <ross.lagerwall@xxxxxxxxxx> wrote:
> @@ -791,9 +807,7 @@ do{ asm volatile (                                        
>               \
>                       [stub] "rm" (stub.func) );                         \
>      if ( unlikely(~res_.raw) )                                          \
>      {                                                                   \
> -        gprintk(XENLOG_WARNING,                                         \
> -                "exception %u (ec=%04x) in emulation stub (line %u)\n", \
> -                res_.fields.trapnr, res_.fields.ec, __LINE__);          \
> +        invoke_stub_exception(res_.fields.trapnr, res_.fields.ec);      \

This presumably is the worst of the changes in this series, as
explained in reply to the overview mail: The text address is going
to point into a huge function, and reconstruction of the source
line is going to be rather cumbersome in case line2addr fails
(which afaik it is not unknown for).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel