Re: [Xen-devel] [PATCH] xen: credit2: remove undefined static function __dump_execstate().

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.03.17 at 11:36, <dario.faggioli@xxxxxxxxxx> wrote:
> On Thu, 2017-03-09 at 03:09 -0700, Jan Beulich wrote:
>> > > > On 09.03.17 at 10:54, <dario.faggioli@xxxxxxxxxx> wrote:
>> > 
>> > --- a/xen/common/sched_credit2.c
>> > +++ b/xen/common/sched_credit2.c
>> > @@ -2437,8 +2437,6 @@ csched2_runtime(const struct scheduler *ops,
>> > int cpu,
>> >      return time;
>> >  }
>> >  
>> > -void __dump_execstate(void *unused);
>> 
>> All fine, except the function wasn't static (or else the compiler
>> would
>> have warned about there not being a definition), so perhaps the
>> subject wants to say "undefined function declaration" or some such.
>> 
> Right, of course it's not... sorry. What I was aiming was to somehow
> reinforce the fact that it's only present in this file, but that's not
> really necessary, and 'static' was very wrong a word for that.
> 
> I'd be fine with a subject line like:
> 
> "xen: credit: remove undefined declaration of __dump_execstate()"

Fine with me (with s/credit/credit2/), and I'm fine without resend, but
in the end it's George to judge (unless he gives his ack, deferring to me
to adjust and apply).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel