[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 1/4] ocaml/gen: fix ocaml type/code generator from IDL

  • To: Wei Liu <wei.liu2@xxxxxxxxxx>
  • From: David Scott <dave@xxxxxxxxxx>
  • Date: Mon, 13 Mar 2017 19:55:53 +0000
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 13 Mar 2017 19:56:05 +0000
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=recoil.org; h=content-type :mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; q=dns; s= selector1; b=bbYpXg5J6BsI6aILYTrEnif/hCte4F1WCJ5S7lCm7qLALsfZO+U 8BrVklIJH2MeUQVOXM4dT0twa6U4pKP+P16LdceXTOP72JATWjHpHiwZegNvVwez W7Gl1N+Qgf45Qk5OQVim2vUUHbI9HAOCqxv7Uz8Ygjnhqxao5+3Q/FVI=
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>
> On 13 Mar 2017, at 16:49, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> 
> On Fri, Mar 03, 2017 at 12:25:05PM +0000, Roger Pau Monne wrote:
>> From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
>> 
>> This patch adds support for union members which have their own type name.
>> 
>> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 

Under the assumption that the generated code still compiles ;-) looks ok to me 
too.

Acked-by: David Scott <dave@xxxxxxxxxx>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.

Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.