Re: [Xen-devel] [PATCH v3 5/9] xen/vpci: add handlers to map the BARs

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 19/05/17 16:21, Jan Beulich wrote:
> > > > On 27.04.17 at 16:35, <roger.pau@xxxxxxxxxx> wrote:
> > +                VPCI_BAR_MEM64_LO,
> > +                VPCI_BAR_MEM64_HI,
> > +            } type;
> > +            /* Hardware address. */
> > +            paddr_t paddr;
> > +            /* Guest address where the BAR should be mapped. */
> > +            paddr_t gaddr;
> > +            /* Current guest address where the BAR is mapped. */
> > +            paddr_t mapped_addr;
> Why do you need to track both "should be" and "is" addresses? Also
> I think all three would more naturally be frame numbers.
>
> > +            size_t size;
> Is this enough for e.g. ARM32 (remember this is a common
> header)?
ARM 32 support up to 40 bits address space. So theoretically it would to 
would be possible to have BAR bigger than 4GB.
Also, I have seen quite few use of GENMASK(63...) which is not going to 
work on arm32.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel