Re: [Xen-devel] [RFC PATCH v2 24/25] NUMA: Move CONFIG_NUMA to common Kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.03.17 at 17:53, <vijay.kilari@xxxxxxxxx> wrote:
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -41,6 +41,10 @@ config HAS_GDBSX
>  config HAS_IOPORTS
>       bool
>  
> +config NUMA
> +     def_bool y
> +     depends on HAS_PDX

What makes necessary this dependency?

> --- a/xen/drivers/acpi/Kconfig
> +++ b/xen/drivers/acpi/Kconfig
> @@ -4,6 +4,3 @@ config ACPI
>  
>  config ACPI_LEGACY_TABLES_LOOKUP
>       bool
> -
> -config NUMA
> -     bool

This makes clear that so far this is an option which architectures
are expected to select. I think we want it to remain that way, but
if we didn't you should remove the existing select(s).

Also, does it really matter much whether this is under drivers/acpi/
or common/? After all ACPI appears to be a prereq on ARM too.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel