[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 05/12] x86/apic: Unify interrupt mode setup for SMP-capable system



Hi Thomas,

At 07/03/2017 02:07 AM, Thomas Gleixner wrote:
On Fri, 30 Jun 2017, Dou Liyang wrote:
-static int __init apic_intr_mode_select(void)
+static int __init apic_intr_mode_select(int *upmode)
 {
        /* Check kernel option */
        if (disable_apic) {
@@ -1206,12 +1208,30 @@ static int __init apic_intr_mode_select(void)
        if (!smp_found_config) {
                disable_ioapic_support();

-               if (!acpi_lapic)
+               if (!acpi_lapic) {
                        pr_info("APIC: ACPI MADT or MP tables are not 
detected\n");
+                       *upmode = true;

That store and extra argument is pointless.

+
+                       return APIC_VIRTUAL_WIRE_NO_CONFIG;

You added an extra return code, which you can use exactly for that purpose
at the callsite.


Actually indeed. Great! Why didn't I think of that?


Aside of that, if you use int * then use numbers, if you use bool then use
true/false. But mixing that is horrible.


Yes, it is, I will remove the 'upmode' argument.


Thanks,

        dou.

+               }

Thanks,

        tglx






_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.