Re: [Xen-devel] [PATCH 1/25] VIOMMU: Add vIOMMU helper functions to create, destroy and query capabilities

[Lan Tianyu <tianyu.lan@xxxxxxxxx>]

On 2017年07月04日 15:34, Julien Grall wrote:
> Hi,
> 
> On 07/04/2017 02:46 AM, Lan Tianyu wrote:
>> Hi Wei:
>>            Thanks for your review.
>>
>> On 2017年06月30日 21:05, Wei Liu wrote:
>>> On Thu, Jun 29, 2017 at 01:50:33AM -0400, Lan Tianyu wrote:
>>> [...]
>>>> > diff --git a/xen/common/Kconfig b/xen/common/Kconfig
>>>> > index dc8e876..8ba4f5a 100644
>>>> > --- a/xen/common/Kconfig
>>>> > +++ b/xen/common/Kconfig
>>>> > @@ -73,6 +73,18 @@ config TMEM
>>>> >   >         If unsure, say Y.
>>>> >   > +config VIOMMU
>>>> > +    def_bool y
>>>> > +    depends on X86
>>> This depends on x86 but the code is in common/. What's the game plan /
>>> expectation here?
>>>
>> The code is general but so far only x86 uses the vIOMMU framework
>> and Julien hope it is disabled on ARM. So only build in vIOMMU codes
>> on x86.
> 
> That's right, at the moment the code is unusable for ARM and I would
> prefer to keep this disabled. I can't tell when we will be able to
> support vIOMMU for ARM and whether we will use this interface.
> 
> If it is always enable on x86, it might be better to use HAS_VIOMMU and
> select from the x86 Kconfig. Limiting the "depends on x86" in the common
> code.
> 

Hi Julien:
     Thanks for your suggestion. That sounds good and will update in the
new version.

-- 
Best regards
Tianyu Lan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel