Re: [Xen-devel] [PATCH v4 06/16] osstest: add a FreeBSD host install recipe

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v4 06/16] osstest: add a FreeBSD host install 
recipe"):
> The installation is performed using the bsdinstall tool, which is part
> of the FreeBSD base system. The installer image is setup with the
> osstest ssh keys and sshd enabled by default, which allows the test
> harness to just ssh into the box, create the install config file and
> launch the scripted install.
...
> diff --git a/ts-freebsd-host-install b/ts-freebsd-host-install
> new file mode 100755
> index 00000000..fcc185c8
> --- /dev/null
> +++ b/ts-freebsd-host-install
> +tsreadconfig();
> +
> +our %xopts;

This variable seems never to be used.

> +our $path_prefix = $r{"freebsd_distpath"} ||
> +                   get_stashed("path_freebsddist", $r{"freebsdbuildjob"});
> +
> +sub get_sets_path () {
> +    my @paths;
> +
> +    foreach my $set (@sets, "MANIFEST") {
> +        push @paths, { name => "$set", path => "$path_prefix/$set" };
> +    }
> +
> +    return @paths;
> +}

You might want to consider abolishing this function (which has one
call site) and simply transferring the "$path_prefix/$set" (which is
the only knowledge that this function provides) to the call site.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel