Re: [Xen-devel] [PATCH v13 09/23] x86: refactor psr: L3 CAT: set value: assemble features value array.

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx> 07/06/17 4:07 AM >>>
>Only can one COS ID be used by one domain at one time. That means all enabled
>features' COS registers at this COS ID are valid for this domain at that time.
>
>When user updates a feature's value, we need make sure all other features'
>values are not affected. So, we firstly need gather an array which contains
>all features current values and replace the setting feature's value in array
>to new value.
>
>Then, we can try to find if there is a COS ID on which all features' COS
>registers values are same as the array. If we can find, we just use this COS
>ID. If fail to find, we need pick a new COS ID.
>
>This patch implements value array assembling flow.
>
>Signed-off-by: Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>
>Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

This was perhaps premature because of ...

>v13:
    >- remove an unnecessary blank line.
      >(suggested by Jan Beulich)
    >- add a new function 'skip_prior_features()' to skip value array according
      >to feature type. This function will be used in later patches too.

... this.

>+static int skip_prior_features(uint32_t **val,
>+                               unsigned int *array_len,
>+                               enum psr_feat_type feat_type)
>+{
>+    unsigned int i;
>+
>+    for ( i = 0; i < feat_type; i++ )
>+    {
>+        const struct feat_props * props = feat_props[i];

Stray blank after *. Other than that you can retain the R-b, and the cosmetic
issue here could be taken care of while committing if no other need arises for
sending another version.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel