Re: [Xen-devel] [PATCH v4 01/17] rbtree: changes to inline coding conventions with Linux tree

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.07.17 at 07:07, <kpraveen.lkml@xxxxxxxxx> wrote:
> On Tue, 2017-07-04 at 02:24 -0600, Jan Beulich wrote:
>> > > > On 03.07.17 at 21:58, <kpraveen.lkml@xxxxxxxxx> wrote:
>> > The patch inlines the rbtree related files to Linux coding
>> > conventions to have
>> > limited conflicts in future while porting from Linux tree.
>> 
>> "inlines" has a different meaning most of the time - how about
>> "brings in line" (but I'll be happy to be corrected by a native
>> speaker)? This would then also call for a change to the subject.
>> 
>> What I'm missing though is a reference to the Linux version to
>> compare with - this is especially relevant because the format
>> the patch brings the code into is not normal Linux style (but I
>> do see that e.g. in 3.0 such oddities indeed existed).
> 
> Is it ok to add the last reference from Linux tree, which has already
> been ported to Xen code base till date, so that we can diff from start
> and verify that its only coding style changed and not anything else ?

Without you saying what you mean by "add last reference" I'm
afraid I can't really answer your question. For example, if you
mean to add a note that things up to, say, 4.12 have been
ported (by you), then this wouldn't be the full truth, as you're
leaving out certain pieces.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel