Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.06.17 at 21:30, <sgoel@xxxxxxxxxxxxxx> wrote:
> Add limited support for parsing IORT table to initialize SMMU devices.
> 
> Signed-off-by: Sameer Goel <sgoel@xxxxxxxxxxxxxx>
> ---
>  xen/arch/arm/setup.c                |   3 +
>  xen/drivers/acpi/Makefile           |   1 +
>  xen/drivers/acpi/arm/Makefile       |   1 +
>  xen/drivers/acpi/arm/iort.c         | 232 
> +++++++++++++++++++-----------------

With the amount of changes done to this file I question even more
the value of first pulling in the plain Linux commits.

> --- a/xen/include/xen/lib.h
> +++ b/xen/include/xen/lib.h
> @@ -9,7 +9,12 @@
>  #include <asm/bug.h>
>  
>  #define BUG_ON(p)  do { if (unlikely(p)) BUG();  } while (0)
> -#define WARN_ON(p) do { if (unlikely(p)) WARN(); } while (0)
> +#define WARN_ON(p) ({                                      \
> +    int __ret_warn_on = !!(p);                             \
> +    if (unlikely(__ret_warn_on))                           \
> +        WARN();                                            \
> +    unlikely(__ret_warn_on);                               \
> +})

This has nothing to do with the intention of the patch. If you want
WARN_ON()s behavior to change, please submit a separate patch
doing just that.

> --- a/xen/include/xen/pci.h
> +++ b/xen/include/xen/pci.h
> @@ -88,6 +88,7 @@ struct pci_dev {
>  #define PT_FAULT_THRESHOLD 10
>      } fault;
>      u64 vf_rlen[6];
> +    struct device dev;

Why? Please rationalize your changes in the patch description (and
perhaps split them).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel