Re: [Xen-devel] [PATCH v6 09/14] arm/guest_access: Move vgic_access_guest_memory to guest_access.h

[Julien Grall <julien.grall@xxxxxxx>]

On 18/07/17 10:49, Sergej Proskurin wrote:
> Hi Julien,
Hello Sergej,

> On 07/17/2017 05:38 PM, Julien Grall wrote:
> > Hi Sergej,
> >
> > On 06/07/17 12:50, Sergej Proskurin wrote:
> > > This commit moves the function vgic_access_guest_memory to guestcopy.c
> > > and the header asm/guest_access.h. No functional changes are made.
> > > Please note that the function will be renamed in the following commit.
> > >
> > > Signed-off-by: Sergej Proskurin <proskurin@xxxxxxxxxxxxx>
> > Acked-by: Julien Grall <julien.grall@xxxxxxx>
> Through Travis CI, I have noticed that clang had troubles compiling the
> source, as it missed some types in  guest_access.h. I fixed it by
> including <xen/types.h> in guest_access.h. With this change, may I keep
> your Acked-by or remove it in the next version?
I can't tell whether this is the right thing to do without seen the 
error commit message.
But I am a bit surprised that Travis CI is trying to build Xen ARM with 
clang...  Last time at looked at it, I remember some missing patches in 
Xen to use clang.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel