Re: [Xen-devel] [PATCH v4 5/9] xen/pci: split code to size BARs from pci_add_device

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Thu, Jul 20, 2017 at 03:00:40PM +0100, Roger Pau Monne wrote:
> On Fri, Jul 14, 2017 at 04:33:20AM -0600, Jan Beulich wrote:
> > >>> On 30.06.17 at 17:01, <roger.pau@xxxxxxxxxx> wrote:
> > > +                if ( ret < 0 )
> > > +                    break;
> > 
> > ASSERT(ret) ?
> 
> Really? This is different from the previous behavior, that would just
> break out of the loop in this situation. And on non-debug builds we
> would end up decreasing i, which is not good.

Figured that out, you wanted me to just add the ASSERT to make sure
ret != 0.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel