[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] libxl: do not start dom0 qemu for stubdomain when not needed
On Fri, Jul 28, 2017 at 06:05:13PM +0200, Marek Marczykowski-Górecki wrote: > On Fri, Jul 28, 2017 at 04:17:51PM +0100, Wei Liu wrote: > > On Thu, Jul 27, 2017 at 12:44:25AM +0200, Marek Marczykowski-Górecki wrote: > > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > > > index 44ebd70..c9aefe15 100644 > > > --- a/tools/libxl/libxl_dm.c > > > +++ b/tools/libxl/libxl_dm.c > > > @@ -1868,13 +1868,17 @@ void libxl__spawn_stub_dm(libxl__egc *egc, > > > libxl__stub_dm_spawn_state *sdss) > > > ret = libxl__domain_build_info_setdefault(gc, &dm_config->b_info); > > > if (ret) goto out; > > > > > > - GCNEW(vfb); > > > - GCNEW(vkb); > > > - libxl__vfb_and_vkb_from_hvm_guest_config(gc, guest_config, vfb, vkb); > > > - dm_config->vfbs = vfb; > > > - dm_config->num_vfbs = 1; > > > - dm_config->vkbs = vkb; > > > - dm_config->num_vkbs = 1; > > > + if (libxl_defbool_val(guest_config->b_info.u.hvm.vnc.enable) || > > > + libxl_defbool_val(guest_config->b_info.u.hvm.spice.enable) || > > > + libxl_defbool_val(guest_config->b_info.u.hvm.sdl.enable)) { > > > > Indentation. > > Should it really be indented at the same level as the code inside this > block? Looks misleading (you need to look for ") {" to see where > condition ends). That's how existing code in libxl is like, isn't it? _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |