Re: [Xen-devel] [PATCH 1/5] mm: Initialize lowmem virq when boot-time scrubbing is disabled

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Aug 29, 2017 at 01:09:13PM -0400, Boris Ostrovsky wrote:
[...]
> diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
> index 9fa62d2..e1f7cd2 100644
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -1839,7 +1839,7 @@ static int __init find_non_smt(unsigned int node, 
> cpumask_t *dest)
>   * Scrub all unallocated pages in all heap zones. This function uses all
>   * online cpu's to scrub the memory in parallel.
>   */
> -void __init scrub_heap_pages(void)
> +static void __init scrub_heap_pages(void)
>  {

Since you now guard against opt_bootscrub in heap_init_late, you should
remove the check of opt_bootscrub in this function.

With this fixed:

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel