Re: [Xen-devel] [PATCH 1/5] mm: Initialize lowmem virq when boot-time scrubbing is disabled

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.08.17 at 19:09, <boris.ostrovsky@xxxxxxxxxx> wrote:
> @@ -1970,12 +1970,15 @@ void __init scrub_heap_pages(void)
>  #ifdef CONFIG_SCRUB_DEBUG
>      boot_scrub_done = true;
>  #endif
> +}
>  
> -    /* Now that the heap is initialized, run checks and set bounds
> -     * for the low mem virq algorithm. */
> +void __init heap_init_late(void)
> +{
>      setup_low_mem_virq();
> -}
>  
> +    if ( opt_bootscrub )
> +        scrub_heap_pages();
> +}

Any reason you fully remove that comment? I think the "run checks"
part is stale (if it was ever valid in the first place), but the rest
could more or less stay.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel