Re: [Xen-devel] [PATCH 08/12] arm/bootfdt.c: switch to plain bool

[Julien Grall <julien.grall@xxxxxxx>]

Hi Wei,

On 09/15/2017 10:42 AM, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

> ---
>   xen/arch/arm/bootfdt.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index ea188a08b1..4a687e725d 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -16,8 +16,8 @@
>   #include <xsm/xsm.h>
>   #include <asm/setup.h>
>   
> -static bool_t __init device_tree_node_matches(const void *fdt, int node,
> -                                              const char *match)
> +static bool __init device_tree_node_matches(const void *fdt, int node,
> +                                            const char *match)
>   {
>       const char *name;
>       size_t match_len;
> @@ -31,8 +31,8 @@ static bool_t __init device_tree_node_matches(const void 
> *fdt, int node,
>           && (name[match_len] == '@' || name[match_len] == '\0');
>   }
>   
> -static bool_t __init device_tree_node_compatible(const void *fdt, int node,
> -                                                 const char *match)
> +static bool __init device_tree_node_compatible(const void *fdt, int node,
> +                                               const char *match)
>   {
>       int len, l;
>       int mlen;
> @@ -42,17 +42,17 @@ static bool_t __init device_tree_node_compatible(const void 
> *fdt, int node,
>   
>       prop = fdt_getprop(fdt, node, "compatible", &len);
>       if ( prop == NULL )
> -        return 0;
> +        return false;
>   
>       while ( len > 0 ) {
>           if ( !dt_compat_cmp(prop, match) )
> -            return 1;
> +            return true;
>           l = strlen(prop) + 1;
>           prop += l;
>           len -= l;
>       }
>   
> -    return 0;
> +    return false;
>   }
>   
>   static void __init device_tree_get_reg(const __be32 **cell, u32 address_cells,
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel