Re: [Xen-devel] [PATCH 09/12] arm/decode.c: switch to plain bool

[Julien Grall <julien.grall@xxxxxxx>]

Hi Wei,

On 09/15/2017 10:42 AM, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>   xen/arch/arm/decode.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
> index 514b7a21a5..795d126f02 100644
> --- a/xen/arch/arm/decode.c
> +++ b/xen/arch/arm/decode.c
> @@ -26,7 +26,7 @@
>   #include "decode.h"
>   
>   static void update_dabt(struct hsr_dabt *dabt, int reg,
> -                        uint8_t size, bool_t sign)
> +                        uint8_t size, bool sign)
You probably want to switch from 0 to false all the callers of update_dabt.

Regardless that:

Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

>   {
>       dabt->reg = reg;
>       dabt->size = size;
> @@ -47,8 +47,8 @@ static int decode_thumb2(register_t pc, struct hsr_dabt 
> *dabt, uint16_t hw1)
>       {
>       case 12:
>       {
> -        bool_t sign = !!(hw1 & (1 << 8));
> -        bool_t load = !!(hw1 & (1 << 4));
> +        bool sign = (hw1 & (1u << 8));
> +        bool load = (hw1 & (1u << 4));
>   
>           if ( (hw1 & 0x0110) == 0x0100 )
>               /* NEON instruction */
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel