Re: [Xen-devel] [OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume device

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("Re: [OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume 
device"):
> On Fri, Oct 20, 2017 at 12:05:55PM +0100, Ian Jackson wrote:
> > Wei Liu writes ("[OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume 
> > device"):
> > > See code comment for explanation.
> > ...
> > > +    # There might be stale entries in /etc/initramfs-tools/conf.d/resume
> > > +    # which get stored in the initramfs. That introduces delay in guest 
> > > booting
> > > +    # which might cause tests to fail.
> > 
> > Why might there be such stale entries ?
> 
> The ramdisk is taken from the host, which contains that file. The resume
> device is going to point to the swap partition in the host.

Ah.  Hrm.  I guess this was always a bit of a bodge.

> > > +    # Override that in kernel command line with the correct swap 
> > > partition.
> > > +    $cfg =~ m/'phy:.+-swap,(xvda\d+),.*'/;
> > > +    $extra .= " resume=/dev/$1";
> > > +    logm("change resume device to $1");
> > 
> > Alternatively, if indeed this is necessary and not due to bugs,
> > perhaps it should be done by xen-tools ?
> 
> No, see the first paragraph. xen-tools can't be expected to modify the
> ramdisk.

Maybe it should set the appropriate "extra" though.  IIRC xen-tools
does implement this sort-of-trick of reusing the hosts initrd.  So why
does this bug not happen with other users of xen-tools ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel