[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [RFC v2 2/7] arm64: Add definitions for fwnode_handle
- To: "Goel, Sameer" <sgoel@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, julien.grall@xxxxxxx, mjaggi@xxxxxxxxxxxxxxxxxx
- From: Julien Grall <julien.grall@xxxxxxxxxx>
- Date: Tue, 24 Oct 2017 15:08:20 +0100
- Cc: sstabellini@xxxxxxxxxx, wei.liu2@xxxxxxxxxx, george.dunlap@xxxxxxxxxxxxx, Andrew.Cooper3@xxxxxxxxxx, jbeulich@xxxxxxxx, Ian.Jackson@xxxxxxxxxx, nd@xxxxxxx, robin.murphy@xxxxxxx, shankerd@xxxxxxxxxxxxxx
- Delivery-date: Tue, 24 Oct 2017 14:08:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
Hi Sameer,
On 19/10/17 15:53, Goel, Sameer wrote:
On 10/12/2017 6:45 AM, Julien Grall wrote:
On 21/09/17 01:37, Sameer Goel wrote:
This will be used as a device property to match the DMA capable devices
with the associated SMMU. The header file is a port from linux. The code
was changed to remove the types that were not needed for Xen.
I think you probably want a bit more context in the commit message about
implement fwnode.h in common code.
Within this series, fwnode seems to only be used by Arm. So what would be the
advantage to get that in xen/? Is it going to be used by x86 or taken advantage
in common code?
Linux ChangeId:ce793486e23e: driver core / ACPI: Represent ACPI
companions using fwnode_handle
Signed-off-by: Sameer Goel <sgoel@xxxxxxxxxxxxxx>
---
xen/include/asm-arm/device.h | 2 ++
xen/include/xen/fwnode.h | 33 +++++++++++++++++++++++++++++++++
2 files changed, 35 insertions(+)
create mode 100644 xen/include/xen/fwnode.h
diff --git a/xen/include/asm-arm/device.h b/xen/include/asm-arm/device.h
index 6734ae8..78c38fe 100644
--- a/xen/include/asm-arm/device.h
+++ b/xen/include/asm-arm/device.h
@@ -2,6 +2,7 @@
#define __ASM_ARM_DEVICE_H
#include <xen/init.h>
+#include <xen/fwnode.h>
enum device_type
{
@@ -19,6 +20,7 @@ struct device
#ifdef CONFIG_HAS_DEVICE_TREE
struct dt_device_node *of_node; /* Used by drivers imported from Linux */
I was expecting a todo in the code after the discussion about leave of_node
here.
#endif
+ struct fwnode_handle *fwnode; /*fw device node identifier */
The fwnode handle was provide a match cookie for the SMMUs and not much else.
Even with this around we will need the
dt info in the device node. I agree that this rolls up into fw spec and I can
look at the code cleanup for the next patch.
A clean-up patch would be great but not necessary. What I expect is a
TODO mentioning the possible clean-up.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
