Re: [Xen-devel] [PATCH v3 2/4] x86emul: Support vpclmulqdq

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.11.17 at 11:36, <yang.zhong@xxxxxxxxx> wrote:
> @@ -7672,7 +7673,12 @@ x86_emulate(
>          host_and_vcpu_must_have(pclmulqdq);
>          if ( vex.opcx == vex_none )
>              goto simd_0f3a_common;
> -        generate_exception_if(vex.l, EXC_UD);
> +        if ( !vex.l )
> +        {
> +            generate_exception_if(vex.l, EXC_UD);

What's the point of this?

> +            goto simd_0f_imm8_avx;
> +        }
> +        host_and_vcpu_must_have(vpclmulqdq);

Why not simply

        if ( vex.l )
            host_and_vcpu_must_have(vpclmulqdq);

?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel