[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/HVM: don't retain emulated insn cache when exiting back to guest

Hi Andrew,

On 12/06/2017 03:08 PM, Andrew Cooper wrote:
On 06/12/17 13:04, Julien Grall wrote:
Hi Jan,

On 12/06/2017 12:58 PM, Jan Beulich wrote:
On 06.12.17 at 12:47, <julien.grall@xxxxxxxxxx> wrote:
On 12/06/2017 11:45 AM, Jan Beulich wrote:
On 06.12.17 at 10:47, <julien.grall@xxxxxxxxxx> wrote:
I guess I have been CCed because you would like this patch is
fixing the
regression you mentioned on IRC?

Yes, but first of all we need to see whether the issue goes away in
master once the patch is in.

Would reverting the offending patch in Xen 4.10 be solution?

Probably yes, at the price of re-introducing the issue that change
did fix. But reverting wouldn't feel right: The change, after all,
was not buggy - it merely uncovered the other issue, as far as we
can tell.

I understand. I have seen you pushed the fixes in master today. Let
see how it perform and decide tomorrow what to do.

XenServer testing has identified this bug, and shown the bug to be fixed
with this patch in place.

Therefore, a retroactive Tested-by: Andrew Cooper

No other emulation issues seen running windows on this particular piece
of old AMD hardware.

Thank you for doing regresison tests! On that basis:

Release-acked-by: Julien Grall <julien.grall@xxxxxxxxxx>


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.