Re: [Xen-devel] [PATCH v2 2/3] x86/setup: do not relocate Xen over current Xen image placement

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Thu, Dec 07, 2017 at 04:51:32AM -0700, Jan Beulich wrote:
> >>> On 04.12.17 at 11:24, <daniel.kiper@xxxxxxxxxx> wrote:
> > --- a/xen/arch/x86/setup.c
> > +++ b/xen/arch/x86/setup.c
> > @@ -962,7 +962,12 @@ void __init noreturn __start_xen(unsigned long mbi_p)
> >          }
> >          else
> >              end = 0;
> > -        if ( end > s )
> > +
> > +        /*
> > +         * Is the region size greater than zero and does it begins
>
> begin

Yep.

> > +         * above or at the end of current Xen image placement?
>
> Without being a native speaker I think this commonly is "at or
> above", not the other way around. But I'd be happy to be told
> that this other form is equally frequently being used.

OK.

> > +         */
> > +        if ( (end > s) && (end - reloc_size >= _end - _start) )
>
> In your earlier mails following v1 you had __pa(_end) here on the
> right side. Why is this _end - _start again now (which is 2Mb too
> little imo with the current XEN_IMG_OFFSET value)?

(end - reloc_size + XEN_IMG_OFFSET >= __pa(_end)) and
(end - reloc_size >= _end - _start) are equal.

You should remember that there is nothing to copy between 0 and XEN_IMG_OFFSET.

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel