Re: [Xen-devel] [PATCH v2 2/3] x86/setup: do not relocate Xen over current Xen image placement

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.12.17 at 15:59, <daniel.kiper@xxxxxxxxxx> wrote:
> On Thu, Dec 07, 2017 at 04:51:32AM -0700, Jan Beulich wrote:
>> >>> On 04.12.17 at 11:24, <daniel.kiper@xxxxxxxxxx> wrote:
>> > +        if ( (end > s) && (end - reloc_size >= _end - _start) )
>>
>> In your earlier mails following v1 you had __pa(_end) here on the
>> right side. Why is this _end - _start again now (which is 2Mb too
>> little imo with the current XEN_IMG_OFFSET value)?
> 
> (end - reloc_size + XEN_IMG_OFFSET >= __pa(_end)) and

If you used this expression, I think I could live without it having a
comment.

> (end - reloc_size >= _end - _start) are equal.
> 
> You should remember that there is nothing to copy between 0 and 
> XEN_IMG_OFFSET.

If, however, you want to stick to the expression you currently use,
I think this very much needs a comment.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel