[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC v1 06/74] tools/libelf: fix elf notes check for PVH guest

>>> On 04.01.18 at 14:05, <wei.liu2@xxxxxxxxxx> wrote:
> PVH only requires PHYS32_ENTRY to be set. Return immediately if that's
> the case.

So I guess the bug(?) being fixed is that so far loader or guest_os,
and xen_ver settings are also required. However, you fail to mention
_why_ you think they're not required. I can sort of see this for
loader and maybe guest_os, but for the Xen version this isn't as
obvious, mainly because any arguments I can think of right now
would equally apply to PV.

> --- a/xen/common/libelf/libelf-dominfo.c
> +++ b/xen/common/libelf/libelf-dominfo.c
> @@ -381,6 +381,13 @@ static elf_errorstatus elf_xen_note_check(struct 
> elf_binary *elf,
>           return 0;
>      }
> +    /* PVH only requires one ELF note to be set */
> +    if ( parms->phys_entry != UNSET_ADDR32 )
> +    {
> +        elf_msg(elf, "ELF: Found PVH image\n");
> +        return 0;
> +    }

If the other entries are of no interest for PVH, I think that this
then calls for dropping their logging from pvh_load_kernel().
I'm also surprised that I can't find any use of any of the three
values checked in libxc.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.