Re: [Xen-devel] [PATCH v2 15/23] vixen: pass through version hypercalls to parent Xen

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Sun, Jan 07, 2018 at 12:28:31PM -0800, Anthony Liguori wrote:
> From: Anthony Liguori <aliguori@xxxxxxxxxx>
> 
> This is necessary to trigger event channel upcalls but it is also
> useful to passthrough the full version information such that the
> guest believes it is running on the parent Xen.
> 
> Signed-off-by: Matt Wilson <msw@xxxxxxxxxx>
> Signed-off-by: Anthony Liguori <aliguori@xxxxxxxxxx>
> ---
> v1 -> v2
>  - don't pass through version by default
>  - introduce vixen_ptver parameter to enable version passthrough.
> ---
>  xen/arch/x86/guest/vixen.c        |  7 +++
>  xen/common/kernel.c               | 89 
> +++++++++++++++++++++++++++++++++------
>  xen/include/asm-arm/guest/vixen.h |  5 +++
>  xen/include/asm-x86/guest/vixen.h |  2 +
>  4 files changed, 91 insertions(+), 12 deletions(-)
> 
> diff --git a/xen/arch/x86/guest/vixen.c b/xen/arch/x86/guest/vixen.c
> index a1614e0..7c886a2 100644
> --- a/xen/arch/x86/guest/vixen.c
> +++ b/xen/arch/x86/guest/vixen.c
> @@ -31,8 +31,10 @@ static int in_vixen;
>  static int vixen_domid = 1;
>  static uint32_t vixen_reserved_mem_pgstart = 0xfeff0000;
>  static shared_info_t *global_si;
> +static bool vixen_ptver;
>  
>  integer_param("vixen_domid", vixen_domid);
> +boolean_param("vixen_ptver", vixen_ptver);

Would it make sense to have a custom parameter function that would
be called 'vixen' and have all of those in it?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel