Re: [Xen-devel] [PATCH 1/6] x86: move invocations of hvm_flush_guest_tlbs()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 19/01/18 16:02, Jan Beulich wrote:
> Their need is not tied to the actual flushing of TLBs, but the ticking
> of the TLB clock. Make this more obvious by folding the two invocations
> into a single one in pre_flush().
>
> Also defer the latching of CR4 in write_cr3() until after pre_flush()
> (and hence implicitly until after IRQs are off), making operation
> sequence the same in both cases (eliminating the theoretical risk of
> pre_flush() altering CR4). This then also improves register allocation,
> as the compiler doesn't need to use a callee-saved register for "cr4"
> anymore.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel