Re: [Xen-devel] [PATCH RFC] firmware/shim: fix Xen tree setup

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Feb 01, 2018 at 03:11:28AM -0700, Jan Beulich wrote:
> >>> On 01.02.18 at 11:01, <roger.pau@xxxxxxxxxx> wrote:
> > On Wed, Jan 31, 2018 at 09:55:21AM -0700, Jan Beulich wrote:
> >> --- a/tools/firmware/xen-dir/Makefile
> >> +++ b/tools/firmware/xen-dir/Makefile
> >> @@ -16,18 +16,18 @@ DEP_FILES=$(foreach i, $(LINK_FILES), $(
> >>  
> >>  linkfarm.stamp: $(DEP_DIRS) $(DEP_FILES) FORCE
> >>    mkdir -p $(D)
> >> -  set -e
> >>    rm -f linkfarm.stamp.tmp
> >> +  set -e; \
> >>    $(foreach d, $(LINK_DIRS), \
> >>             (mkdir -p $(D)/$(d); \
> >>              cd $(D)/$(d); \
> >>              find $(XEN_ROOT)/$(d)/ -type d |\
> >> -                  sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir -p);)
> >> +                  sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir -p);) \
> >>    $(foreach d, $(LINK_DIRS), \
> >>            (cd $(XEN_ROOT); \
> >> -           find $(d) ! -type l -type f \
> >> -           $(addprefix ! -path , '*.[oda1]' '*.d[12]')) \
> >> -           >> linkfarm.stamp.tmp ; )
> >> +           find $(d) -xtype f \
> > 
> > No xtype please. Does it work with something like:
> > 
> > `find -H $(d) -type f`
> 
> Ah, yes, didn't think of that one. But perhaps -L rather than -H?

Uh, yes, sorry, definitely meant -L.

I guess -H will never be needed, since that would only be helpful when
$(d) is a symbolic link.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel