Re: [Xen-devel] firmware/shim: fix build process to use POSIX find options

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.02.18 at 11:13, <roger.pau@xxxxxxxxxx> wrote:
> On Tue, Jan 30, 2018 at 12:57:28PM -0600, Michael Glasgow wrote:
>> Roger Pau [Monn_] wrote:
>> > On Fri, Jan 26, 2018 at 01:54:30PM -0600, Michael Glasgow wrote:
>> > > This recent patch can be simplified a bit.  (The patch below is
>> > > untested, just a suggestion.)
>> > 
>> > Thanks, this LGTM, but it needs your Signed-off-by tag in order to be
>> > applied.
>> 
>> Simplify posix-friendly changes a bit.
>> 
>> Signed-off-by: Michael Glasgow <glasgow@xxxxxxxx>
> 
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> With one nit...
> 
>> ---
>> 
>> diff -ur a/tools/firmware/xen-dir/Makefile b/tools/firmware/xen-dir/Makefile
>> --- a/tools/firmware/xen-dir/Makefile   2018-01-26 11:40:00.711389605 -0600
>> +++ b/tools/firmware/xen-dir/Makefile   2018-01-26 11:51:41.279825142 -0600
>> @@ -20,9 +20,8 @@
>>         rm -f linkfarm.stamp.tmp
>>         $(foreach d, $(LINK_DIRS), \
>>                  (mkdir -p $(D)/$(d); \
>> -                 cd $(D)/$(d); \
>> -                 find $(XEN_ROOT)/$(d)/ -type d -exec sh -c \
>> -                     "echo {} | sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir 
>> -p"
>>  \;);)
>> +                 cd $(D)/$(d) && \
> 
> There should be no need for the '&&', all this chunk should be
> executed with 'set -e', so please restore the previous ';'.

As you've seen from the patch I've sent - "should be" != "is".
The way it's currently placed the "set -e" has no effect at all.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel