Re: [Xen-devel] [PATCH] build: remove shim related targets

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.02.18 at 09:23, <roger.pau@xxxxxxxxxx> wrote:
> There's no need to have shim specific targets, so just use the regular
> xen makefile targets in order to build the shim binary.
> 
> When the shim is build as part of the firmware directory use the
> xen-syms as the shim binary.

Why the (much larger) xen-syms instead of xen?

> --- a/tools/firmware/xen-dir/Makefile
> +++ b/tools/firmware/xen-dir/Makefile
> @@ -48,10 +48,10 @@ shim-%config: $(D) FORCE
>               KCONFIG_CONFIG=$(CURDIR)/shim.config
>  
>  xen-shim: $(D) shim-olddefconfig
> -     $(MAKE) -C $(D)/xen install-shim \
> +     $(MAKE) -C $(D)/xen build \

install-xen ?

>               XEN_CONFIG_EXPERT=y \
> -             KCONFIG_CONFIG=$(CURDIR)/shim.config \
> -             DESTDIR=$(CURDIR)
> +             KCONFIG_CONFIG=$(CURDIR)/shim.config
> +     cp $(D)/xen/xen-syms xen-shim

ln? Or do here what was done ...

> @@ -149,11 +149,6 @@ $(TARGET)-syms: prelink.o xen.lds 
> $(BASEDIR)/common/symbols-dummy.o
>               >$(@D)/$(@F).map
>       rm -f $(@D)/.$(@F).[0-9]*
>  
> -# Use elf32-x86-64 if toolchain support exists, elf32-i386 otherwise.
> -$(TARGET)-shim: FORMAT = $(firstword $(filter elf32-x86-64,$(shell 
> $(OBJCOPY) --help)) elf32-i386)
> -$(TARGET)-shim: $(TARGET)-syms
> -     $(OBJCOPY) -O $(FORMAT) $< $@

... here so far? The removal of this step would otherwsie require
more explanation - I recall having inquired about this before: If
there was a reason for doing this, if shouldn't be dropped without
saying why the other binary is now suddenly fine, but wasn't back
then. Or alternatively it would need to be clarified that this step
was indeed pointless.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel