Re: [Xen-devel] [PATCH v2] build: remove shim related targets

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Feb 20, 2018 at 02:43:25PM +0000, Wei Liu wrote:
> On Tue, Feb 20, 2018 at 02:37:54PM +0000, Roger Pau Monne wrote:
> >  xen-shim: $(D) shim-olddefconfig
> > -   $(MAKE) -C $(D)/xen install-shim \
> > +   $(MAKE) -C $(D)/xen build \
> >             XEN_CONFIG_EXPERT=y \
> > -           KCONFIG_CONFIG=$(CURDIR)/shim.config \
> > -           DESTDIR=$(CURDIR)
> > +           KCONFIG_CONFIG=$(CURDIR)/shim.config
> > +   ln -sf $(D)/xen/xen xen-shim
> > +   ln -sf $(D)/xen/xen-syms xen-shim-syms
> 
> I'm not sure this is right -- do you get to install the shim to DESTDIR
> like this?

Yes, the file installed is the target, not the symlink itself:

# ls -lah /usr/local/lib/xen/boot/xen-shim
-rw-r--r--  1 root  wheel   1.9M Feb 20 14:36 /usr/local/lib/xen/boot/xen-shim

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel