Re: [Xen-devel] [PATCH v2] build: remove shim related targets

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.02.18 at 15:37, <roger.pau@xxxxxxxxxx> wrote:
> --- a/tools/firmware/xen-dir/Makefile
> +++ b/tools/firmware/xen-dir/Makefile
> @@ -48,13 +48,14 @@ shim-%config: $(D) FORCE
>               KCONFIG_CONFIG=$(CURDIR)/shim.config
>  
>  xen-shim: $(D) shim-olddefconfig
> -     $(MAKE) -C $(D)/xen install-shim \
> +     $(MAKE) -C $(D)/xen build \
>               XEN_CONFIG_EXPERT=y \
> -             KCONFIG_CONFIG=$(CURDIR)/shim.config \
> -             DESTDIR=$(CURDIR)
> +             KCONFIG_CONFIG=$(CURDIR)/shim.config
> +     ln -sf $(D)/xen/xen xen-shim
> +     ln -sf $(D)/xen/xen-syms xen-shim-syms

I think it is advisable to use $@ instead of open coding the target.

> @@ -151,9 +144,6 @@ $(TARGET): delete-unfresh-files
>       $(MAKE) -f $(BASEDIR)/Rules.mk include/asm-$(TARGET_ARCH)/asm-offsets.h
>       $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $(TARGET)
>  
> -$(TARGET)-shim: $(TARGET)
> -     $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $(TARGET)-shim

I think you need to rebase over the change I've committed earlier
today.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel