Re: [Xen-devel] [PATCH v8 01/11] vpci: introduce basic handlers to trap accesses to the PCI config space

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 23/02/18 15:55, Jan Beulich wrote:
> > > > On 23.01.18 at 16:07, <roger.pau@xxxxxxxxxx> wrote:
> > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> > index c9b9546435..98b82680c6 100644
> > --- a/xen/arch/arm/xen.lds.S
> > +++ b/xen/arch/arm/xen.lds.S
> > @@ -65,6 +65,13 @@ SECTIONS
> >          __param_start = .;
> >          *(.data.param)
> >          __param_end = .;
> > +
> > +#if defined(CONFIG_HAS_PCI) && defined(CONFIG_LATE_HWDOM)
Why this is conditional to CONFIG_LATE_HWDOM?

Also, any reason to impose VPCI when CONFIG_HAS_PCI is set and not 
introduce another config? The new config would help to add support for 
PCI in steps in other architectures.
> > +       . = ALIGN(POINTER_ALIGN);
> > +       __start_vpci_array = .;
> > +       *(.data.vpci)
> > +       __end_vpci_array = .;
> > +#endif
> >     } :text
> >   
> >   #if defined(BUILD_ID)
> > @@ -173,6 +180,13 @@ SECTIONS
> >          *(.init_array)
> >          *(SORT(.init_array.*))
> >          __ctors_end = .;
> > +
> > +#if defined(CONFIG_HAS_PCI) && !defined(CONFIG_LATE_HWDOM)
> > +       . = ALIGN(POINTER_ALIGN);
> > +       __start_vpci_array = .;
> > +       *(.data.vpci)
> > +       __end_vpci_array = .;
> > +#endif
> >     } :text
> >     __init_end_efi = .;
> >     . = ALIGN(STACK_SIZE);
> Sadly you forgot to Cc the ARM maintainers. Stefano, Julien, the
> above would require your ack.
>
> Jan
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel