Re: [Xen-devel] [PATCH v8 01/11] vpci: introduce basic handlers to trap accesses to the PCI config space

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Feb 23, 2018 at 04:02:17PM +0000, Julien Grall wrote:
> Hi,
> 
> On 23/02/18 15:55, Jan Beulich wrote:
> > > > > On 23.01.18 at 16:07, <roger.pau@xxxxxxxxxx> wrote:
> > > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> > > index c9b9546435..98b82680c6 100644
> > > --- a/xen/arch/arm/xen.lds.S
> > > +++ b/xen/arch/arm/xen.lds.S
> > > @@ -65,6 +65,13 @@ SECTIONS
> > >          __param_start = .;
> > >          *(.data.param)
> > >          __param_end = .;
> > > +
> > > +#if defined(CONFIG_HAS_PCI) && defined(CONFIG_LATE_HWDOM)
> 
> Why this is conditional to CONFIG_LATE_HWDOM?

Currently PCI config space emulation is limited to Dom0 usage, hence
the setup part of it can live in the init section if not using a late
hardware domain.

> 
> Also, any reason to impose VPCI when CONFIG_HAS_PCI is set and not introduce
> another config? The new config would help to add support for PCI in steps in
> other architectures.

I could do that I guess, unless anyone objects I will add a
CONFIG_VPCI option.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel