Re: [Xen-devel] [PATCH v2 4/5] tools: xenpm: continue to support {set, get}-vcpu-migration-delay

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 02/23/2018 04:41 PM, Dario Faggioli wrote:
> Now that it is possible to get and set the migration
> delay via the SCHEDOP sysctl, use that in xenpm, instead
> of the special purpose libxc interface (which will be
> removed in a following commit).
> 
> The sysctl, however, requires a cpupool-id argument,
> for knowing on which scheduler it is operating on. In
> this case, since we don't want to alter xenpm's command
> line interface, we always use '0', which means xenpm
> will always act on the default cpupool ('Pool-0').
> 
>>From this commit on, `xenpm {set,get}-vcpu-migration-delay'
> commands work again. But that is only for the sake of
> backward compatibility, and their use is deprecated, in
> favour of 'xl sched-credit -s [-c <poolid>] -m <delay>'.
> 
> Signed-off-by: Dario Faggioli <dfaggioli@xxxxxxxx>
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

If we cared about strict behavioral compatibility, we would modify the
xenpm function to set the migration delay for all cpupools; but I think
we can worry about that if anyone complains. :-)

One comment...

> @@ -1087,13 +1097,17 @@ void set_vcpu_migration_delay_func(int argc, char 
> *argv[])
>  
>  void get_vcpu_migration_delay_func(int argc, char *argv[])
>  {
> -    uint32_t value;
> +    struct xen_sysctl_credit_schedule sparam;
> +
> +    printf("WARNING: using xenpm for this purpose is deprecated."
> +           " Check out `xl sched-credit -s'\n");

Should these warnings be to stderr rather than stdout, so that if
anything is manually parsing stout it will continue to work?

Everything else looks good, thanks.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel