Re: [Xen-devel] [PATCH v3] build: remove shim related targets

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Wed, Feb 28, 2018 at 06:25:23AM -0700, Jan Beulich wrote:
> >>> On 28.02.18 at 14:02, <roger.pau@xxxxxxxxxx> wrote:
> > On Wed, Feb 28, 2018 at 05:29:06AM -0700, Jan Beulich wrote:
> >> >>> On 28.02.18 at 12:47, <roger.pau@xxxxxxxxxx> wrote:
> >> > On Wed, Feb 28, 2018 at 04:02:53AM -0700, Jan Beulich wrote:
> >> >> >>> On 21.02.18 at 13:22, <roger.pau@xxxxxxxxxx> wrote:
> >> >> > --- a/tools/firmware/Makefile
> >> >> > +++ b/tools/firmware/Makefile
> >> >> > @@ -8,6 +8,7 @@ endif
> >> >> >  # hvmloader is a 32-bit protected mode binary.
> >> >> >  TARGET      := hvmloader/hvmloader
> >> >> >  INST_DIR := $(DESTDIR)$(XENFIRMWAREDIR)
> >> >> > +DEBG_DIR := $(DESTDIR)$(DEBUG_DIR)$(XENFIRMWAREDIR)
> >> >> 
> >> >> This is screwing up my build, and looking again I can't see how
> >> >> this can be right: Both $(XENFIRMWAREDIR) and $(DEBUG_DIR)
> >> >> are supposed to be ${prefix}-able, yet there clearly should not
> >> >> be an infix resulting from the construction of this path.
> >> > 
> >> > By being prefixable you mean that both XENFIRMWAREDIR and DEBUG_DIR
> >> > can be relative paths?
> >> 
> >> Both should be possible to live in /usr/lib or /usr/local/lib,
> >> for example.
> > 
> > I'm afraid I don't see the issue, could you provide the values of
> > DESTDIR, DEBUG_DIR and XENFIRMWAREDIR that are causing the issue?
> 
> My build issue is because of some tweaking I have to do in order to
> be able to run the tools from the build directory (it's quite sad that
> this still isn't supported "out of the box").
> 
> > Is this because you end up with something like:
> > 
> > /usr/local/lib/debug/usr/local/... in the debug path?
> 
> Indeed (except the first "local" you show wrongly isn't there), just
> that there's some /home/jbeulich/.../ infix, but _no_ such prefix
> (DESTDIR for the reason mentioned above can't be set to
> /home/jbeulich/..., or [I don't recall] either the build breaks or
> things don't work in the end, but needs to be forced to / on the
> make command line; as said I have a compensating tweak
> elsewhere so that the full resulting path is correct everywhere
> _except_ now for DEBG_DIR).

OK, I *think* I understand what's missing here. This would be more
correct as $(DESTDIR)$(prefix)$(DEBUG_DIR)$(XENFIRMWAREDIR).

It looks like DEBUG_DIR wants to be set in Paths.mk.in as you
suggested.

But that raises the question, if prefix=/usr/local this will become:

/usr/local/lib/usr/local/lib/xen/...

Should this instead be:

/usr/local/lib/usr/lib/xen/...

I don't think so, but want to be sure.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel