Re: [Xen-devel] [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 03/09/2018 10:07 AM, Jan Beulich wrote:
>>>> On 08.03.18 at 18:37, <lars.kurth@xxxxxxxxxx> wrote:
>> --- a/SUPPORT.md
>> +++ b/SUPPORT.md
>> @@ -620,6 +620,7 @@ Note that other devices are available but not security 
>> supported.
>>  
>>  ### x86/Emulated platform devices (QEMU):
>>  
>> +    Status, PCI host bridge: Supported
>>      Status, piix3: Supported
> 
> That's way too generic imo: Any chipset will have a host bridge, so
> its support is already included in the statement on which chipset
> emulation(s) we support. By adding what you add, you could again
> raise the expectation that any host bridge implementation in qemu
> is supported.

Yes, when I saw Lars' patch I was trying to remember why those things
weren't already copied over, and was pretty sure there was a good reason.

Are you saying, in effect, that "support for piix3" *implies* support
for the PCI host bridge provided by the piix3 chipset?

If so, "PCI host bridge" was redundant, and may have been put in before
piix3 was specified.

>>  ### x86/Emulated network (QEMU):
>> @@ -633,10 +634,18 @@ Note that other devices are available but not security 
>> supported.
>>      Status, piix3 ide: Supported
>>      Status, ahci: Supported
>>  
>> +### x86/Emulated Storage Image Formats (QEMU):
>> +
>> +    Status, raw: Supported
>> +    Status, qcow: Supported
>> +    Status, qcow2: Supported
>> +    Status, vhd: Supported
>> +    
>>  ### x86/Emulated graphics (QEMU):
>>  
>>      Status, cirrus-vga: Supported
>> -    Status, stgvga: Supported
>> +    Status, stdvga: Supported
>> +    Status, xenfb: Supported
> 
> Just like xen_disk (correctly) isn't listed in the "x86/Emulated storage
> (QEMU)" section, xenfb doesn't belong here imo. It's not an emulated
> device, and is already enumerated in "PV Framebuffer (backend)"
> (just not with the term "xenfb").
> 
>> @@ -650,7 +659,9 @@ Note that other devices are available but not security 
>> supported.
>>      Status, usbtablet: Supported
>>      Status, ps/2 keyboard: Supported
>>      Status, ps/2 mouse: Supported
>> -
>> +    Status, xenfb keyboard: Supported
>> +    Status, xenfb mouse: Supported
> 
> Similarly for these ones and "PV keyboard (backend)". 

Yes, I remember having this discussion.

> Perhaps a
> "PV mouse (backend)" section should be added.

+1

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel