Re: [Xen-devel] [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.03.18 at 11:28, <lars.kurth@xxxxxxxxxx> wrote:
> On 09/03/2018, 11:07, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
> 
>     >>> On 08.03.18 at 18:37, <lars.kurth@xxxxxxxxxx> wrote:
>     > --- a/SUPPORT.md
>     > +++ b/SUPPORT.md
>     > @@ -620,6 +620,7 @@ Note that other devices are available but not 
> security supported.
>     >  
>     >  ### x86/Emulated platform devices (QEMU):
>     >  
>     > +    Status, PCI host bridge: Supported
>     >      Status, piix3: Supported
>     
>     That's way too generic imo: Any chipset will have a host bridge, so
>     its support is already included in the statement on which chipset
>     emulation(s) we support. By adding what you add, you could again
>     raise the expectation that any host bridge implementation in qemu
>     is supported.
> 
> I thought this may be an issue. I would be quite happy to change it, but 
> would need to know how to phrase it.
> Suggestions?

Just drop this addition of a line.

>     >  ### x86/Emulated graphics (QEMU):
>     >  
>     >      Status, cirrus-vga: Supported
>     > -    Status, stgvga: Supported
>     > +    Status, stdvga: Supported
>     > +    Status, xenfb: Supported
>     
>     Just like xen_disk (correctly) isn't listed in the "x86/Emulated storage
>     (QEMU)" section, xenfb doesn't belong here imo. It's not an emulated
>     device, and is already enumerated in "PV Framebuffer (backend)"
>     (just not with the term "xenfb").
> 
> So, what I read from this, the existing line 
> 
> ### PV Framebuffer (backend)
>     Status, QEMU: Supported
> 
> covers the back-end.

Yes.

>     > @@ -650,7 +659,9 @@ Note that other devices are available but not 
> security supported.
>     >      Status, usbtablet: Supported
>     >      Status, ps/2 keyboard: Supported
>     >      Status, ps/2 mouse: Supported
>     > -
>     > +    Status, xenfb keyboard: Supported
>     > +    Status, xenfb mouse: Supported
>     
>     Similarly for these ones and "PV keyboard (backend)". Perhaps a
>     "PV mouse (backend)" section should be added.
>  
> So to clarify, 
> 
> ### PV keyboard (backend)
>     Status, QEMU: Supported
> ### PV mouse (backend)
>     Status, QEMU: Supported
> 
> would cover this in your view?

Yes.

> Does this cover all the bases, or did I miss anything? 

With s/bases/backends/ - yes, I think so.

> In other words, are there any frontend bits for xenfb (framebuffer, 
> keyboard, mouse) that would need to be recorded somewhere

The frontend are in the guest OSes anyway, and they all have their
own sections (looks like as for the backends there's "keyboard" but
not "mouse"; in both cases not unlikely because they live close
together).

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel