Re: [Xen-devel] [PATCH v1] getpageframeinfo3: replace hardcoded batchsize with constant

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 03/09/2018 04:55 PM, Olaf Hering wrote:
> The point was to document the counter part. Grep -w 1024 is not helpful.

Of course -- your patch certainly makes the codebase better by making
this number set in only one place, and in making it easier to find who
else is depending on this number with grep.

Jan is saying, however, it's not clear why we have such an arbitrary
limit in the first place.  Andy claims it's a remnant from the days when
we were passing a single page rather than an arbitrary array; it also
serves to  make sure the hypercall doesn't run too long.  But if we use
normal hypercall preemption, we don't need to have this limit at all.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel