Re: [Xen-devel] [PATCH v2 1/4] x86/PVHv2: Add memory map pointer to hvm_start_info struct

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.03.18 at 21:07, <maran.wilson@xxxxxxxxxx> wrote:
> OK, I think I'm following the specifics now. But just to make sure we 
> all on the same page before sending out the next version...
> 
> I'll be adding something like the following to the header file:
> 
> ...
> /*
>   * For x86 implementations at least, the values used in the type field 
> of the
>   * memory map table entries are defined below and match the Address 
> Range Types
>   * as defined in section 15 (System Address Map Interfaces) of the ACPI
>   * Specification (http://uefi.org/specifications)
>   */
> #define PVH_MEMMAP_TYPE_RAM       1
> #define PVH_MEMMAP_TYPE_RESERVED  2
> #define PVH_MEMMAP_TYPE_ACPI      3
> #define PVH_MEMMAP_TYPE_NVS       4
> #define PVH_MEMMAP_TYPE_UNUSABLE  5
> #define PVH_MEMMAP_TYPE_PMEM      7
> ...
> 
> And then we will find an appropriate place in the c code to add a couple 
> of BUILD_BUG_ON() macros to make sure the above remain consistent with 
> E820_xxx.
> 
> Does that sound about right?

About, yes. Subject to the name prefix adjustment as per the other
reply (to Boris) just sent. Plus I'm not convinced of the x86
restriction here: There's nothing x86-specific about these in the
ACPI spec.

Additionally, please either avoid referring to doc sections by number,
or also give the ACPI version so that the number changing in a future
revision won't cause the comment to become stale.

Finally please include all values defined by ACPI 6.2.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel